kanboard: init at 1.2.42 #357229
kanboard: init at 1.2.42 #357229
Conversation
github-actions
bot
added
6.topic: nixos
yzx9
added
8.has: module (new)
github-actions
bot
added
the
8.has: module (update)
ofborg
bot
added
2.status: merge conflict
yzx9
force-pushed
the
feature/kanboard
branch
from
fd3b7e2 to
70e415b
Compare
|
Thanks to @getchoo for the detailed and thoughtful review. I've updated the code according to your suggestions. Please review it again, and feel free to share any further suggestions |
There was a problem hiding this comment.
If I have the time I'll try to actually test this module out locally -- but for now, this looks great!
The only other recommendation I would have is creating a VM test for this module, even if it's as simple as pinging the service once it's up. It's a great way to make sure things are working at a basic level, and helps a ton with updating the module and the package itself. Ping me again if you need any help with it :)
getchoo
added
the
12.approvals: 1
yzx9
force-pushed
the
feature/kanboard
branch
from
70e415b to
2465c78
Compare
|
The test has been added, and some default values have been changed to make the service easier to set up. |
github-actions
bot
added
the
10.rebuild-darwin: 0
yzx9
force-pushed
the
feature/kanboard
branch
from
2465c78 to
59890cd
Compare
ofborg
bot
removed
the
10.rebuild-darwin: 0
yzx9
force-pushed
the
feature/kanboard
branch
from
59890cd to
35d8a2c
Compare
ofborg
bot
removed
the
10.rebuild-darwin: 0
|
@getchoo I have updated this PR. Please review it again. I’ve pushed a commit to facilitate the review, and I will squash it after approval. I hope I haven't misunderstood you this time. |
|
Thank for you detailed review.
nixpkgs/nixos/modules/services/web-apps/anuko-time-tracker.nix Lines 322 to 337 in 7422541 which resulted in an error: |
There was a problem hiding this comment.
Module and package LGTM, OfBorg is happy, and the root option of the virtualHost appears to be working as expected with
{
services.kanboard = {
enable = true;
domain = "example.org";
};
services.nginx.virtualHosts."example.org".root = "/foo/bar";
}Thanks for all your work here! Feel free to ping me again in a couple days if there are no other reviews :)
getchoo
added
the
12.approvals: 1
yzx9
force-pushed
the
feature/kanboard
branch
from
fba69f1 to
127d485
Compare
|
I have squashed the commits |
wegank
removed
the
12.approvals: 1
|
Hello @getchoo, could you take another look at this PR? I haven’t made any changes in the latest squashed commit. 
|
getchoo
added
the
12.approvals: 1
|
@ofborg test kanboard |
yzx9
force-pushed
the
feature/kanboard
branch
from
127d485 to
5401412
Compare
|
@ofborg build kanboard kanboard.passthru.tests Hopefully last build 🤞 |
KanBoard is project management software that focuses on the Kanban methodology.
Previously, Kanboard was added but later removed due to its limited utility. This PR reinstates the package and introduces a NixOS module to facilitate hosting the web application.
close #288788
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.